-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odgi stats consensus graphs #16
Odgi stats consensus graphs #16
Conversation
I suspect https://github.com/nf-core/pangenome/pull/16/checks?check_run_id=1453281628 does not run through because of a too old Nextflow version? For me the following works: nextflow run main.nf --with-docker nfcore/pangenome:dev --input ../HLA-zoo/seqs/DRB1-3123.fa --do_stats |
Maybe we need to bump the Nextflow version to a higher one, again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok, now let me find the lowest Nextflow version number the tests run through. |
I just figured that the next proper release after 20.07.1 is 20.10.0, so we have to stick with this one. |
PR checklist
CHANGELOG.md
is updateddocs
is updatedThis will take care of #10.
This PR only affects
main.nf
.file
withpath
to stick to the DSL2 standard as specified at https://www.nextflow.io/docs/latest/dsl2.html#dsl2-migration-notes.do_stats=false
. If set to true,odgi stats
will be executed for theseqwish
, thesmoothxg
, and theconsensus
graphs.consensus_jump_max
. This specifies the maximum jump in nucleotides of a structural variant to include in the consensus graph. The argument is comma-separated. For each entry, a consensus graph will be generated and statistics will be produced, ifdo_stats=true
.odgiStats
output is copied into the results folder underresults/odgiStats
. Later in the development, the output of this channel will be forwarded toMultiQC
.I was experimenting with
emit
in order to bend Nextflow to my need. However, I am still lacking some experience working with Nextflow. So I suspect that my code does, what I intend it to do. But there might be a neater way in Nextflow to get there. Or I don't stick to some formatting standards. Happy to learn!