Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abritamr/run #7176

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix abritamr/run #7176

wants to merge 4 commits into from

Conversation

sateeshperi
Copy link
Contributor

  • Fix language server issues
  • add stub + test
  • update version
  • update to seqera containers

@sateeshperi sateeshperi self-assigned this Dec 7, 2024
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions but looks good in general :)

process.out.out,
process.out.txt,
process.out.versions,
path(process.out.versions[0]).yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't you just assert
process.out.versions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an alternative option that shows in the nf-test the actual content, which is actually more useful than the md5sum.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh been looking for that for a while - we did want to use that in the stub section, right?

process.out.partials,
process.out.virulence,
process.out.out,
process.out.txt,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this file is optional? Is it always present in the test runs though?

Comment on lines +58 to +67
assertAll(
{ assert snapshot(
process.out.matches,
process.out.partials,
process.out.virulence,
process.out.out,
process.out.txt,
process.out.versions,
path(process.out.versions[0]).yaml
).match() },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the stub why not just do

Suggested change
assertAll(
{ assert snapshot(
process.out.matches,
process.out.partials,
process.out.virulence,
process.out.out,
process.out.txt,
process.out.versions,
path(process.out.versions[0]).yaml
).match() },
{ assert snapshot(process.out).match() }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants