-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix abritamr/run #7176
base: master
Are you sure you want to change the base?
Fix abritamr/run #7176
Conversation
sateeshperi
commented
Dec 7, 2024
- Fix language server issues
- add stub + test
- update version
- update to seqera containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions but looks good in general :)
process.out.out, | ||
process.out.txt, | ||
process.out.versions, | ||
path(process.out.versions[0]).yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't you just assert
process.out.versions
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an alternative option that shows in the nf-test the actual content, which is actually more useful than the md5sum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh been looking for that for a while - we did want to use that in the stub section, right?
process.out.partials, | ||
process.out.virulence, | ||
process.out.out, | ||
process.out.txt, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this file is optional? Is it always present in the test runs though?
assertAll( | ||
{ assert snapshot( | ||
process.out.matches, | ||
process.out.partials, | ||
process.out.virulence, | ||
process.out.out, | ||
process.out.txt, | ||
process.out.versions, | ||
path(process.out.versions[0]).yaml | ||
).match() }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the stub why not just do
assertAll( | |
{ assert snapshot( | |
process.out.matches, | |
process.out.partials, | |
process.out.virulence, | |
process.out.out, | |
process.out.txt, | |
process.out.versions, | |
path(process.out.versions[0]).yaml | |
).match() }, | |
{ assert snapshot(process.out).match() } |