-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Module: NACHO_QC #7108
New Module: NACHO_QC #7108
Conversation
modules/nf-core/nacho/qc/main.nf
Outdated
@@ -0,0 +1,79 @@ | |||
nextflow.enable.moduleBinaries = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to have this added into the tests/nextflow.config file and then adding the line "config "./nextflow.config" to the main.nf.test file. Just because the docs https://www.nextflow.io/docs/latest/module.html#module-binaries say to add them in the config or pipeline file, and also because no other module seems to set this type of parameters directly in the main.nf file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good to me
* initialize module * update test * Remove TO-DO from main.nf.test * Remove comment from main.nf.test * update test after meta component in output channels * split channel into png and txt outputs * update meta file * move moduleBinaries to test nextflow config
PR checklist
Closes Nanostring #112
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
Do you know who wrote the original local module for Nanostring? So we can give propper credit