Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbmm2/align #6903

Merged
merged 29 commits into from
Oct 31, 2024
Merged

pbmm2/align #6903

merged 29 commits into from
Oct 31, 2024

Conversation

tanyasarkjain
Copy link
Contributor

@tanyasarkjain tanyasarkjain commented Oct 29, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@tanyasarkjain tanyasarkjain added the new module Adding a new module label Oct 29, 2024
@tanyasarkjain tanyasarkjain changed the title Pbmm2 pbmm2/align Oct 29, 2024
Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! A few comments, but looks good overall!

modules/nf-core/pbmm2/align/main.nf Outdated Show resolved Hide resolved
modules/nf-core/pbmm2/align/main.nf Outdated Show resolved Hide resolved
modules/nf-core/pbmm2/align/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/pbmm2/align/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/pbmm2/align/main.nf Outdated Show resolved Hide resolved
modules/nf-core/pbmm2/align/main.nf Outdated Show resolved Hide resolved
modules/nf-core/pbmm2/align/meta.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@famosab famosab linked an issue Oct 31, 2024 that may be closed by this pull request
4 tasks
@famosab famosab added this pull request to the merge queue Oct 31, 2024
Merged via the queue into nf-core:master with commit 7f3ea5d Oct 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: pbmm2/align
4 participants