-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parabricks/fq2bam version updated and tests migrated to nftest #6882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to update these declarations (at least I got some errors):
def metrics_output_command = args = "--out-duplicate-metrics duplicate-metrics.txt" ? "touch duplicate-metrics.txt" : "" def known_sites_output_command = known_sites ? "touch ${prefix}.table" : "" def qc_metrics_output_command = args = "--out-qc-metrics-dir qc_metrics " ? "mkdir qc_metrics && touch qc_metrics/alignment.txt" : ""
to
def metrics_output_command = args.contains("--out-duplicate-metrics duplicate-metrics.txt") ? "touch duplicate-metrics.txt" : ""
def known_sites_output_command = known_sites ? "touch ${prefix}.table" : ""
def qc_metrics_output_command = args.contains("--out-qc-metrics-dir qc_metrics ") ? "mkdir qc_metrics && touch qc_metrics/alignment.txt" : ""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just a note if we run into errors later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be careful: i think the meta should not be changed, it seems that this now adheres to. an older structure
tag "parabricks" | ||
tag "parabricks/fq2bam" | ||
|
||
test("parabricks_fq2bam_pe_default") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test("parabricks_fq2bam_pe_default") { | |
test("sarscov2 - fastq.gz - paired-end") { |
|
||
} | ||
|
||
test("parabricks_fq2bam_se_default") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test("parabricks_fq2bam_se_default") { | |
test("sarscov2 - fastq.gz - single-end") { |
|
||
} | ||
|
||
test("parabricks_fq2bam_se_default_stub") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test("parabricks_fq2bam_se_default_stub") { | |
test("sarscov2 - fastq.gz - single-end - stub") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this came from the pytest, right? I do not think we really need this anymore but we need to take care that all of this is reflected in the new nf-test
solved with #6902 |
PR checklist
Closes #6860
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda