Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parabricks/fq2bam version updated and tests migrated to nftest #6882

Closed
wants to merge 13 commits into from

Conversation

bojangles2002
Copy link

PR checklist

Closes #6860

  • [ X ] This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • [ X ] Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@bojangles2002 bojangles2002 requested a review from a team as a code owner October 29, 2024 10:48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to update these declarations (at least I got some errors):
def metrics_output_command = args = "--out-duplicate-metrics duplicate-metrics.txt" ? "touch duplicate-metrics.txt" : "" def known_sites_output_command = known_sites ? "touch ${prefix}.table" : "" def qc_metrics_output_command = args = "--out-qc-metrics-dir qc_metrics " ? "mkdir qc_metrics && touch qc_metrics/alignment.txt" : ""
to

    def metrics_output_command = args.contains("--out-duplicate-metrics duplicate-metrics.txt") ? "touch duplicate-metrics.txt" : ""
    def known_sites_output_command = known_sites ? "touch ${prefix}.table" : ""
    def qc_metrics_output_command = args.contains("--out-qc-metrics-dir qc_metrics ") ? "mkdir qc_metrics && touch qc_metrics/alignment.txt" : ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a note if we run into errors later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be careful: i think the meta should not be changed, it seems that this now adheres to. an older structure

tag "parabricks"
tag "parabricks/fq2bam"

test("parabricks_fq2bam_pe_default") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test("parabricks_fq2bam_pe_default") {
test("sarscov2 - fastq.gz - paired-end") {


}

test("parabricks_fq2bam_se_default") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test("parabricks_fq2bam_se_default") {
test("sarscov2 - fastq.gz - single-end") {


}

test("parabricks_fq2bam_se_default_stub") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test("parabricks_fq2bam_se_default_stub") {
test("sarscov2 - fastq.gz - single-end - stub") {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this came from the pytest, right? I do not think we really need this anymore but we need to take care that all of this is reflected in the new nf-test

@famosab
Copy link
Contributor

famosab commented Oct 30, 2024

solved with #6902

@famosab famosab closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update module: parabricks/fq2bam
3 participants