Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Module: humid #5493

Merged
merged 6 commits into from
Apr 17, 2024
Merged

New Module: humid #5493

merged 6 commits into from
Apr 17, 2024

Conversation

Joon-Klaps
Copy link
Contributor

PR checklist

Closes #5484

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@Joon-Klaps Joon-Klaps requested a review from a team as a code owner April 17, 2024 11:14
@Joon-Klaps Joon-Klaps linked an issue Apr 17, 2024 that may be closed by this pull request
new module: HUMID #5484
Closed
4 tasks
@Joon-Klaps Joon-Klaps requested review from vagkaratzas and removed request for a team April 17, 2024 11:14
matthdsm
matthdsm requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, looks good otherwise

modules/nf-core/humid/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/humid/meta.yml Show resolved Hide resolved
modules/nf-core/humid/meta.yml Show resolved Hide resolved
matthdsm
matthdsm approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Joon-Klaps Joon-Klaps added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@Joon-Klaps
Copy link
Contributor Author

@matthdsm, had to modify tests a little bit, checksum on the log was inconsistent. I'm guessing it's inconsistent as the log file also includes computation time.

@Joon-Klaps Joon-Klaps added this pull request to the merge queue Apr 17, 2024
Merged via the queue into master with commit c417458 Apr 17, 2024
11 checks passed
@Joon-Klaps Joon-Klaps deleted the 5484-new-module-humid branch April 17, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthdsm matthdsm matthdsm approved these changes

@vagkaratzas vagkaratzas Awaiting requested review from vagkaratzas vagkaratzas was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
new module Adding a new module Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: HUMID
2 participants
@Joon-Klaps @matthdsm