Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port manta-tumoronly to nf-test #5363

Merged
merged 5 commits into from
Mar 21, 2024
Merged

port manta-tumoronly to nf-test #5363

merged 5 commits into from
Mar 21, 2024

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Mar 21, 2024

PR checklist

Closes #5361

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@famosab famosab requested review from maxulysse, nvnieuwk and a team as code owners March 21, 2024 13:18
@famosab famosab added this pull request to the merge queue Mar 21, 2024
@famosab famosab mentioned this pull request Mar 21, 2024
Closed
Merged via the queue into nf-core:master with commit 8731a62 Mar 21, 2024
11 checks passed
@famosab famosab deleted the manta-tumor-test branch March 21, 2024 14:36
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
@famosab
port manta-tumoronly to nf-test (nf-core#5363)
cfaad20 
* feat: add tumoronly tests

* fix: adjust stub test for gz

* fix remove old pytest files

* snapshot

* remove empty config
tucano pushed a commit to tucano/modules that referenced this pull request Mar 22, 2024
@famosab @tucano
port manta-tumoronly to nf-test (nf-core#5363)
5bd742f 
* feat: add tumoronly tests

* fix: adjust stub test for gz

* fix remove old pytest files

* snapshot

* remove empty config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@nvnieuwk nvnieuwk Awaiting requested review from nvnieuwk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port manta/tumoronly to nf-test
2 participants
@famosab @maxulysse