Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module nanofilt #5290

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Add module nanofilt #5290

merged 5 commits into from
Mar 20, 2024

Conversation

lfreitasl
Copy link
Contributor

@lfreitasl lfreitasl commented Mar 19, 2024 •
edited
Loading

PR checklist

Closes #5285

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@lfreitasl lfreitasl requested a review from a team as a code owner March 19, 2024 18:13
@lfreitasl lfreitasl requested review from leoisl and removed request for a team March 19, 2024 18:13
@lfreitasl lfreitasl self-assigned this Mar 19, 2024
mahesh-panchal
mahesh-panchal reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, although there are some guidelines that are not met.

modules/nf-core/nanofilt/main.nf Outdated Show resolved Hide resolved
modules/nf-core/nanofilt/main.nf Outdated Show resolved Hide resolved
mahesh-panchal
mahesh-panchal approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from small things, LGTM

modules/nf-core/nanofilt/main.nf Outdated Show resolved Hide resolved
modules/nf-core/nanofilt/main.nf Outdated Show resolved Hide resolved
modules/nf-core/nanofilt/meta.yml Outdated Show resolved Hide resolved
@lfreitasl lfreitasl added this pull request to the merge queue Mar 20, 2024
Merged via the queue into nf-core:master with commit fc63cd1 Mar 20, 2024
11 checks passed
@lfreitasl lfreitasl deleted the nanofilt branch March 20, 2024 13:39
jvfe added a commit that referenced this pull request Mar 20, 2024
@jvfe
Merge branch 'master' into nf-test_phispy
a2bedc0 
* master:
  Add module nanofilt (#5290)
  Tcoffee tcs (#5288)
  Add and update - picard/gatk4 - addorreplacereadgroups (#5302)
  New module svtypersso (#5311)
jvfe added a commit to jvfe/modules that referenced this pull request Mar 20, 2024
@jvfe
Merge branch 'master' into nf-test_islandpath
1359ace 
* master:
  Add module nanofilt (nf-core#5290)
tucano pushed a commit to tucano/modules that referenced this pull request Mar 20, 2024
@lfreitasl @tucano
Add module nanofilt (nf-core#5290)
cc16942 
* Add module nanofilt

* Add module nanofilt with corrections in meta.yaml and main.nf

* Add reviewer suggestions

* Add last changes of review
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@lfreitasl @jennylsmith
Add module nanofilt (nf-core#5290)
5f82e67 
* Add module nanofilt

* Add module nanofilt with corrections in meta.yaml and main.nf

* Add reviewer suggestions

* Add last changes of review
alexnater pushed a commit to alexnater/nf-core-modules that referenced this pull request Mar 21, 2024
@lfreitasl
Add module nanofilt (nf-core#5290)
8f476ca 
* Add module nanofilt

* Add module nanofilt with corrections in meta.yaml and main.nf

* Add reviewer suggestions

* Add last changes of review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-panchal mahesh-panchal mahesh-panchal approved these changes

@leoisl leoisl Awaiting requested review from leoisl leoisl was automatically assigned from nf-core/nf-test

Assignees

@lfreitasl lfreitasl

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: nanofilt
2 participants
@lfreitasl @mahesh-panchal