Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update learnmsa module to work with compressed files. #5276
Update learnmsa module to work with compressed files. #5276
Changes from 8 commits
2cd688d
75eb724
a83a122
aa6db78
8b9ed24
057d1e3
5829c4e
dc009bb
ebf507a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does have the 1 in it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get the output file from the meta + file-output channel, if you mean the
.get(1)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nvm, for the snapshot name of the versions snapshot it's because since v 0.8.4 nf-test throws an error when overwriting a snapshot with the same name – compare [0].
This was causing the CI to fail despite the test passing locally (where I have nf-test v 0.8.3 installed).
[0] askimed/nf-test@d2508b2#diff-fd31905853152ac935c5509db52bb497033040fa8cb2523810950c3595ba450aR31-R37
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.