Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: kraken2/build #5212
New module: kraken2/build #5212
Changes from all commits
bade906
5cb769e
0faa53c
4c38491
22ca018
525fd1e
d68f9fa
a4bce9c
ffbdef5
b475a23
52f1e3b
ce57507
22bf016
96f73d2
21346f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this matches KRAKEN2_ADD, it doesn't seem to match the main KRAKEN2_KRAKEN2 module, maybe it's worth bumping that (depending what the differences are?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The container in the
KRAKEN2_KRAKEN2
module failed with theadd
module (as far as I remember), maybe we could try the mulled container with theKRAKEN2_KRAKEN2
module and check if it works or not (?).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly - basically try to have them all in line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. But we can try that later I guess.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.