Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bakta: amrfinder database issue #5048

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

jasmezz
Copy link
Contributor

@jasmezz jasmezz commented Mar 4, 2024

This fixes a crash of bakta when using the automatically downloaded database with bakta (reported here).
It does not seem to be a conda-only issue. I could reproduce it with singularity as well, that's why I execute the amrfinder_update line regard of the profile.

(The memory requirement in the config file was decreased only because GHA complained.)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jasmezz jasmezz requested review from rpetit3 and jfy133 as code owners March 4, 2024 13:25
@jasmezz jasmezz mentioned this pull request Mar 4, 2024
14 tasks
Copy link
Contributor

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasmezz
Copy link
Contributor Author

jasmezz commented Mar 5, 2024

Thanks for checking, @christopher-mohr! 🚀

@jasmezz jasmezz added this pull request to the merge queue Mar 5, 2024
@jasmezz jasmezz changed the title Fix bakta when using conda profile Fix bakta: amrfinder database issue Mar 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 5, 2024
@jasmezz jasmezz added this pull request to the merge queue Mar 5, 2024
Merged via the queue into nf-core:master with commit fff61a9 Mar 5, 2024
10 checks passed
@jasmezz jasmezz deleted the fix-bakta-conda branch March 5, 2024 14:34
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
* Force-update database when using conda profile

* Decrease resource request for test run, update database command
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
* Force-update database when using conda profile

* Decrease resource request for test run, update database command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants