Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump chromap 0.2.4 #3285

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Bump chromap 0.2.4 #3285

merged 4 commits into from
Apr 14, 2023

Conversation

JoseEspinosa
Copy link
Member

PR checklist

Bump chromap version 0.2.4 to chromap/chromap and chromap/index

Closes #3281 #3283

  • This comment contains a description of changes (with reason).
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@JoseEspinosa JoseEspinosa marked this pull request as ready for review April 14, 2023 09:23
subwaystation
subwaystation approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@subwaystation subwaystation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoseEspinosa JoseEspinosa added this pull request to the merge queue Apr 14, 2023
Merged via the queue into nf-core:master with commit d6b7b1f Apr 14, 2023
@JoseEspinosa JoseEspinosa mentioned this pull request Apr 17, 2023
Closed
This was referenced Apr 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subwaystation subwaystation subwaystation approved these changes

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Chromap version 0.2.4 in chromap/index
2 participants
@JoseEspinosa @subwaystation