Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clair3 #3058

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Clair3 #3058

wants to merge 12 commits into from

Conversation

yuukiiwa
Copy link
Contributor

@yuukiiwa yuukiiwa commented Mar 20, 2023

conda environment couldn't be resolved

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@edmundmiller edmundmiller requested a review from a team as a code owner October 19, 2023 16:26
conda 'bioconda::clair3=1.0.0'
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity/clair3:1.0.0--py39hb9dc472_1' :
'quay.io/biocontainers/clair3:1.0.0--py39hb9dc472_1' }"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'quay.io/biocontainers/clair3:1.0.0--py39hb9dc472_1' }"
'biocontainers/clair3:1.0.0--py39hb9dc472_1' }"

Comment on lines 16 to 17
tuple val(meta), path("${meta.id}/*") , emit: vcf
path "versions.yml" , emit: versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tuple val(meta), path("${meta.id}/*") , emit: vcf
path "versions.yml" , emit: versions
tuple val(meta), path("${meta.id}/*") , emit: vcf
path "versions.yml" , emit: versions

"${task.process}":
clair3: \$( /usr/local/bin/run_clair3.sh --version | sed 's/Clair3 v//' )
END_VERSIONS
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend adding a stub: section

Comment on lines +4 to +5
- clair3
- short-variant calling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- clair3
- short-variant calling
- germline
- short-variant calling
- long-reads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants