Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meryl and merqury #63

Merged
merged 27 commits into from
Oct 29, 2024
Merged

Add meryl and merqury #63

merged 27 commits into from
Oct 29, 2024

Conversation

stephenturner
Copy link
Contributor

@stephenturner stephenturner commented Oct 28, 2024

Merqury is a tool for genome quality assessment that uses k-mer counts from raw sequencing data to evaluate the accuracy and completeness of a genome assembly. Meryl is the companion tool that efficiently counts and stores k-mers from sequencing reads, enabling Merqury to estimate metrics like assembly completeness and base accuracy. These tools provide a k-mer-based approach to assess assembly quality, helping to identify potential errors or gaps.​

@GallVp
Copy link
Member

GallVp commented Oct 28, 2024

Nice work @stephenturner

Would be great to support the trio mode with parental reads. This is supported by the assemblyqc pipeline. Maybe, we can extract a sub workflow, put it on nf-core/modules so that the two pipelines can benefit from shared development. Please see the workflow on the assemblyqc repo:

https://github.com/Plant-Food-Research-Open/assemblyqc/blob/cec2728d0785d97e0e9493558c83d83d0b48240e/workflows/assemblyqc.nf#L598-L771

- add new test_with_merqury profile
- Added test_with_merqury profile to import in nextflow.config
- revert test profile to no longer set `merqury_skip` to false (skips merqury by default)
fixes nf-core#67
…ilter out fq channel items if no fq is provided or if not named appropriately, and make merqury conditional upon not skipping AND fq provided nf-core#62
@stephenturner stephenturner self-assigned this Oct 29, 2024
@stephenturner
Copy link
Contributor Author

Noting that one of the test commands isn't going to run until nf-core/test-datasets#1365 is merged, which updates samplesheets in test-datasets

@chriswyatt1
Copy link
Contributor

Test datasets is merged now

@stephenturner stephenturner merged commit 5e5f897 into nf-core:dev Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants