Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logo #333

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Add logo #333

merged 6 commits into from
Jan 14, 2025
+34,172 −261

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fetchngs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse maxulysse changed the base branch from master to dev January 13, 2025 18:21
@nf-core nf-core deleted a comment from github-actions bot Jan 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 738fdfb

+| ✅ 165 tests passed       |+
#| ❔  15 tests were ignored |#

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: assets/nf-core-fetchngs_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-fetchngs_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-fetchngs_logo_dark.png
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config
  • modules_config - modules_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2025-01-13 18:28:28

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@maxulysse maxulysse mentioned this pull request Jan 13, 2025
Merged
@nf-core nf-core deleted a comment from github-actions bot Jan 13, 2025
LeonHafner
LeonHafner reviewed Jan 13, 2025
View reviewed changes
Copy link

@LeonHafner LeonHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the svg files the hyphen shadow alignment seems off. Is this only my browser (Safari & Chrome)?
Screenshot 2025-01-13 at 20 23 19

@LeonHafner
Copy link

Seems like that is only the case in GitHub where the font is not loaded: https://nfcore.slack.com/archives/CE7DN1U7M/p1728465889462289
The logo looks great 🚀

LeonHafner
LeonHafner approved these changes Jan 13, 2025
View reviewed changes
Copy link

@LeonHafner LeonHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxulysse maxulysse merged commit a24ba1d into nf-core:dev Jan 14, 2025
63 of 81 checks passed
@maxulysse maxulysse deleted the add_logo branch January 14, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonHafner LeonHafner LeonHafner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @nf-core-bot @LeonHafner