Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.7 Patch #984

Merged
merged 7 commits into from
May 16, 2023
Merged

2.4.7 Patch #984

merged 7 commits into from
May 16, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented May 16, 2023

Closes #983 and a broken conda environment

Tested by manually editing environment to bump the pygments to the minimal version as reported in teh error, and then linted with nf-core tools 1.9

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested a review from a team May 16, 2023 09:20
@github-actions
Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --config .github/markdownlint.yml --fix
    • Manually resolve anything left from markdownlint . --config .github/markdownlint.yml

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TCLamnidis
Copy link
Collaborator

@aidaanva was adamant that we should also bump MultiQC to fix a division by 0 error. Is there a reason why we don't? and if we do, maybe double check that the dependencies work with it 👀

Copy link
Collaborator

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial approval. see my comment. I am fine either way, but if the latest MQC version fixes a bug in one of the modules, it seems like a good time to add that too.

CHANGELOG.md Show resolved Hide resolved
@jfy133 jfy133 merged commit 631f18e into master May 16, 2023
@jfy133 jfy133 deleted the patch branch May 16, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiQC error
3 participants