-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added missing label mc_small to mtnucratio #751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the changelog, but otherwise simple enough ;).
That said, I actually think mtnucratio
doesn't use multi-threading, I think sc_small
might be therefore more suitable? @apeltzer can maybe confirm though - if your past reports say it uses two CPUs (alhougth this might be the fall-back setting in the eager base config)
Good point for multi-threading, I have based it only on the fact that the execution report would show me 110 - 150% use of the allocated CPU which I suppose is 1 by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will wait for tests to pass then merge 👍 thanks very much!
|
Ok the failure is in something that's being fixed with another PR, so this is good enough 👍 |
Chose the option with 2 CPUs from my past execution reports.
PR checklist
nf-core lint .
).nextflow run . -profile test_tsv,singularity
).CHANGELOG.md
is updated.