Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition preventing to run multivcfanalyzer #711

Merged
merged 6 commits into from
Mar 29, 2021
Merged

Fix condition preventing to run multivcfanalyzer #711

merged 6 commits into from
Mar 29, 2021

Conversation

maxibor
Copy link
Member

@maxibor maxibor commented Mar 24, 2021

A bit of cleanup and fixing a parameter type to allow to run MultiVCFAnalyzer

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • CHANGELOG.md is updated.

@maxibor
Copy link
Member Author

maxibor commented Mar 25, 2021

Merged dev branch back into PR branch to sync with template update @jfy133

@github-actions
Copy link

github-actions bot commented Mar 25, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d11de6a

+| ✅ 189 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗  26 tests had warnings |!
### ❗ Test warnings:
  • conda_env_yaml - Conda dep outdated: conda-forge::python=3.7.3, 3.9.2 available
  • conda_env_yaml - Conda dep outdated: conda-forge::markdown=3.2.2, 3.3.4 available
  • conda_env_yaml - Conda dep outdated: conda-forge::pymdown-extensions=7.1, 8.1.1 available
  • conda_env_yaml - Conda dep outdated: conda-forge::pygments=2.6.1, 2.8.1 available
  • conda_env_yaml - Conda dep outdated: conda-forge::openjdk=8.0.144, 11.0.9.1 available
  • conda_env_yaml - Conda dep outdated: bioconda::adapterremoval=2.3.1, 2.3.2 available
  • conda_env_yaml - Conda dep outdated: bioconda::picard=2.22.9, 2.25.1 available
  • conda_env_yaml - Conda dep outdated: bioconda::samtools=1.9, 1.12 available
  • conda_env_yaml - Conda dep outdated: bioconda::angsd=0.933, 0.935 available
  • conda_env_yaml - Conda dep outdated: bioconda::gatk4=4.1.7.0, 4.2.0.0 available
  • conda_env_yaml - Conda dep outdated: bioconda::gatk=3.5, 3.8 available
  • conda_env_yaml - Conda dep outdated: bioconda::damageprofiler=0.4.9, 1.1 available
  • conda_env_yaml - Conda dep outdated: bioconda::bedtools=2.29.2, 2.30.0 available
  • conda_env_yaml - Conda dep outdated: conda-forge::libiconv=1.15, 1.16 available
  • conda_env_yaml - Conda dep outdated: conda-forge::pigz=2.3.4, 2.6 available
  • conda_env_yaml - Conda dep outdated: bioconda::preseq=2.0.3, 3.1.2 available
  • conda_env_yaml - Conda dep outdated: bioconda::bamutil=1.0.14, 1.0.15 available
  • conda_env_yaml - Conda dep outdated: bioconda::pysam=0.15.4, 0.16.0 available
  • conda_env_yaml - Conda dep outdated: conda-forge::pandas=1.0.4, 1.2.3 available
  • conda_env_yaml - Conda dep outdated: bioconda::freebayes=1.3.2, 1.3.5 available
  • conda_env_yaml - Conda dep outdated: conda-forge::biopython=1.76, 1.78 available
  • conda_env_yaml - Conda dep outdated: conda-forge::xopen=0.9.0, 1.1.0 available
  • conda_env_yaml - Conda dep outdated: bioconda::bowtie2=2.4.1, 2.4.2 available
  • conda_env_yaml - Conda dep outdated: bioconda::mapdamage2=2.2.0, 2.2.1 available
  • conda_env_yaml - Conda dep outdated: bioconda::bbmap=38.87, 38.90 available
  • conda_env_yaml - Conda dep outdated: conda-forge::tbb=2020.2, 2021.1.1 available

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.md
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: assets/multiqc_config.yaml

✅ Tests passed:

Run details

  • nf-core/tools version 1.13.2
  • Run at 2021-03-25 13:31:34

jfy133
jfy133 reviewed Mar 25, 2021
View reviewed changes
main.nf Show resolved Hide resolved
jfy133
jfy133 requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need a CHANGELOG update and good to go

@maxibor
Copy link
Member Author

maxibor commented Mar 26, 2021

Changelog updated @jfy133

@jfy133
Copy link
Member

jfy133 commented Mar 26, 2021

Fix markdown lint and you can merge @maxibor! (ignore nf-core linting issue)

@jfy133 jfy133 merged commit 6532e74 into nf-core:dev Mar 29, 2021
@jfy133 jfy133 mentioned this pull request Apr 6, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxibor @jfy133