-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kraken db loading fromPath #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fail :(
Error executing process > 'decomp_kraken'
Caused by:
Process `decomp_kraken` terminated with an error exit status (1)
Command executed:
tar xvzf eager_test.tar.gz
mkdir -p eager_test
mv *.k2d eager_test
Command exit status:
1
Command output:
eager_test/
eager_test/opts.k2d
eager_test/seqid2taxid.map
eager_test/taxo.k2d
eager_test/hash.k2d
Command error:
mv: cannot stat '*.k2d': No such file or directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above about CI fail
Guessing from the conversation still some fixes required no ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This in principle to me now looks good. CI tests do pass (the one fail is the flakiness on the BAM filtering thing).
@maxibor please decide if you want to change fromPath
to file()
(see Harshil's comment), and then proceed with merging!
As I can't see |
Feel free to merge! <- SCRAP THAT! See Slack - only one sample was run, needs a |
Yeah add either |
Went with |
See slack - solves the issue 👍🏻 |
Kraken database loading fixed to
fromPath
method for channel creationPR checklist
nf-core lint .
).nextflow run . -profile test,docker
).CHANGELOG.md
is updated.