Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GATK genotyping modules. #232

Merged
merged 68 commits into from
Sep 5, 2019
Merged

Added GATK genotyping modules. #232

merged 68 commits into from
Sep 5, 2019

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Aug 13, 2019

This includes modules for genotyping (VCF creation) with GATK UnifiedGenotyper and GATK Haplotyper caller.

Note: GATK UnifiedGenotyper firstly downloads the GATK 3.5 jar file, which has the last working version of GATK used in EAGER1 @MPI-SHH. Pathogen people at MPI-SHH currently require the specific VCF format from 3.5 as later versions modify this and does not work with a downstream tool currently.

The implementation mostly matches EAGER1 functionality other than the 'additional parameter' flag. Not included is ANGSD or SNP filtering.

(Sorry for messy/too many commits; this was a learning experience for me ;))

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo [NOT REQUIRED]
  • Ensure the test suite passes (nextflow run . -profile test,docker) [RAN WITH OWN TESTS].
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated [NOT REQUIRED]

Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a separate entry in the scrape_software_versions.py script to parse the GATK3.X version information, too.

@jfy133
Copy link
Member Author

jfy133 commented Sep 5, 2019

Added, and the pipeline runs through 'successfully' but I don't see any output from that script? There isn't an error in the .nextflow.log to suggest it failed either...

@apeltzer apeltzer changed the base branch from master to GATK-UG September 5, 2019 11:19
@apeltzer
Copy link
Member

apeltzer commented Sep 5, 2019

Thanks for your edits, I'll merge this to branch GATK-UG so we can jointly update this to get it out very soon 👍

@apeltzer apeltzer merged commit 28c541f into nf-core:GATK-UG Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants