-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GATK genotyping modules. #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have a separate entry in the scrape_software_versions.py
script to parse the GATK3.X version information, too.
Added, and the pipeline runs through 'successfully' but I don't see any output from that script? There isn't an error in the |
Thanks for your edits, I'll merge this to branch |
This includes modules for genotyping (VCF creation) with GATK UnifiedGenotyper and GATK Haplotyper caller.
Note: GATK UnifiedGenotyper firstly downloads the GATK 3.5 jar file, which has the last working version of GATK used in EAGER1 @MPI-SHH. Pathogen people at MPI-SHH currently require the specific VCF format from 3.5 as later versions modify this and does not work with a downstream tool currently.
The implementation mostly matches EAGER1 functionality other than the 'additional parameter' flag. Not included is ANGSD or SNP filtering.
(Sorry for messy/too many commits; this was a learning experience for me ;))
PR checklist
nextflow run . -profile test,docker
) [RAN WITH OWN TESTS].nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updated [NOT REQUIRED]Learn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md