Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Skipping FastQC #186

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Add Skipping FastQC #186

merged 4 commits into from
Apr 9, 2019

Conversation

apeltzer
Copy link
Member

@apeltzer apeltzer commented Apr 8, 2019

This adds making FastQC optional in the beginning.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

@apeltzer apeltzer added the WIP Work in progress label Apr 8, 2019
@apeltzer apeltzer requested a review from a team April 8, 2019 11:45
@apeltzer apeltzer removed the WIP Work in progress label Apr 8, 2019
@apeltzer
Copy link
Member Author

apeltzer commented Apr 8, 2019

If anyone fancies doing a review :-)

@apeltzer apeltzer mentioned this pull request Apr 8, 2019
Closed
@apeltzer apeltzer changed the title Add changelog Add Skipping FastQC Apr 8, 2019
@apeltzer apeltzer merged commit 99c807d into nf-core:dev Apr 9, 2019
@apeltzer apeltzer deleted the fastqc-optional branch April 9, 2019 12:33
@jfy133 jfy133 self-requested a review April 9, 2019 19:27
@jfy133
Copy link
Member

jfy133 commented Apr 9, 2019

Retroactive review approval after manual testing ;) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 Awaiting requested review from jfy133

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeltzer @jfy133