-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible AdapterRemoval #159
Conversation
PR release 2.0.5
Co-Authored-By: maxibor <[email protected]>
Co-Authored-By: maxibor <[email protected]>
Add optional merging and trimming
Polish pr
Remove if clause here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
This is just a bit of nitpicking, also I noticed the somewhat inconsistent use of adapter
vs. adaptor
.
I know different tools use different spellings but I think it would be nice to have it consistent for the pipeline params
Co-Authored-By: apeltzer <[email protected]>
Co-Authored-By: apeltzer <[email protected]>
Co-Authored-By: apeltzer <[email protected]>
Fix remaining issue with circularmapper
Fix cardinality issues
I'll be cleaning up the trimming part - its possible to have a predefined command in there for SE/PE mode and get rid of some boilerplate code this way 👍 |
Unfortunately, the output handling with AdapterRemoval makes it a bit complicated to be able to accomodate all cases (PE/SE) into a single condensed version:
So I can't really combine individual steps in all cases, but rather have the same merging and quality trimming options in externalized commans that I use in all cases (which works fine 👍 ) to make the code a bit cleaner and easier to read. I guess once the tests pass, we can basically assume this is fine 👍 |
Polish usage, add changelog
This is based on @maxibor and @jfy133 s work and help and should provide the means to run:
Thereby addressing #137, #64.
PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedThis might require some docs updating (open a PR against the
ar_optional
branch here) and some more testing, as I adjusted some stuff in my PR on top of @maxibor 's.Thanks A BUNCH for helping out on this both!