Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files in channels (follow best practices) #113

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Files in channels (follow best practices) #113

merged 2 commits into from
Dec 17, 2018

Conversation

apeltzer
Copy link
Member

This puts all files into separate channels to follow best practices with data staging in Nextflow.

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • CHANGELOG.md is updated

@apeltzer apeltzer requested a review from jfy133 December 15, 2018 23:53
jfy133
jfy133 approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on this, so I trust you ;).

Can test properly in my next round of whole-pipeline testing

@apeltzer apeltzer merged commit 1f38063 into nf-core:dev Dec 17, 2018
@apeltzer apeltzer deleted the files_in_channels branch December 22, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeltzer @jfy133