Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant UDG flags #112

Merged
merged 7 commits into from
Dec 17, 2018
Merged

Fix redundant UDG flags #112

merged 7 commits into from
Dec 17, 2018

Conversation

apeltzer
Copy link
Member

This addresses #89 directly, also documenting the changes in both changelog and user documentation.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated

@apeltzer apeltzer requested a review from jfy133 December 15, 2018 23:45
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if --udg is set but PMD is not turned on downstream? What other tools utilise this flag?Thinking from a (novice-)user perspective, they might turn that flag on even if they don't want PMD tools.

Secondly, I would rather say --UDGnone instead of --UDGminus. I think this is clearer - at least from the terminology in our institute (i.e. none/half/full).

There is a typo which I've marked in a code comment.

docs/usage.md Outdated Show resolved Hide resolved
@apeltzer apeltzer merged commit 5da8831 into nf-core:dev Dec 17, 2018
@apeltzer apeltzer deleted the pmd_udg_type branch December 22, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants