Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish CM implementation #4

Closed
apeltzer opened this issue Jun 3, 2018 · 2 comments
Closed

Finish CM implementation #4

apeltzer opened this issue Jun 3, 2018 · 2 comments

Comments

@apeltzer
Copy link
Member

apeltzer commented Jun 3, 2018

Missing parts:

Handling SE data
FixPrefix for AR - when to combine which files?
merging vs only clipping for both
@apeltzer apeltzer added this to the 2.0 milestone Jun 3, 2018
@apeltzer
Copy link
Member Author

apeltzer commented Aug 5, 2018

The pipelin should be able to handle these kind of datasets:

  • Single Ended
  • Paired Ended

In both cases, we'd like to see adapters to be removed. Additionally for PE data, there needs to be read merging performed with several output files that are then combined to a single file for downstream analysis.

An example on what is done normally can be found here:

https://github.com/apeltzer/EAGER-CLI/blob/master/src/main/java/Modules/preprocessing/CombineFastQ.java

I personally think we should also get rid of Clip&Merge and just support AdapterRemoval in EAGER2, no need for having two methods when one is anyways outperforming the other in all cases.

@apeltzer apeltzer changed the title Finish AR/CM implementation Finish CM implementation Aug 5, 2018
@apeltzer apeltzer modified the milestone: V2.0 "Gray Wolf" Aug 15, 2018
@apeltzer
Copy link
Member Author

Dropping CM implementation for AdapterRemovalv2 implementation. That should suffice for 99.5% of all projects anyways.

apeltzer pushed a commit that referenced this issue Nov 4, 2018
Upstream change syncing
apeltzer pushed a commit that referenced this issue Feb 27, 2019
Made polyG param clearer what it is
apeltzer pushed a commit that referenced this issue Oct 17, 2019
jfy133 added a commit that referenced this issue Feb 28, 2020
jfy133 added a commit that referenced this issue Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant