-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI Test Implementation #3
Comments
I'll look for: |
Yeah, need to update this ticket still, but this seems reasonable! We'll have some specific tweaks for human vs bacterial vs other stuff, but I'd say for most things it should be fairly identical. |
Actually, speaking of which. How do you envision the tweaks between human/bacterial/other? Is it worth having default modifications that way, or is it better to let the user decide? Just curious, as IIRC the only difference between human and bacterial in EAGER 1.9 was inclusion of QF values in report table. |
Honestly, I don't see that much differences as you said already - the basic processing is identical, with some specific tools for human (e.g. schmutzi for example) and some specific tools for bacteria later (e.g. genConS or similar). One could in theory provide certain profiles that won't run these tools e.g. in the wrong cases but instead keep everything else identical. Yes, thats mostly it. There were ideas to make things even smarter, but that resulted in an entire bunch of things that we'd need to implement for minimal user experience effects... so we instead focused on other things... |
Exactly. Then I suggest we remove organism-specific profiles. Maybe in the documentation we can provide 'suggested' or 'example' settings which the user can then input accordingly? That'll save you some coding work too ;) If you agree - do we still need the different organisms as test data? |
I'm all in on that one |
eager2_mammoth_testing_package.tar.gz Contains:
Let me know if that works/is useful. Edit: File sizes:
|
Thats perfect! Thank you James! I will check this in under https://github.com/nf-core/test-datasets and use it for setting up testcases - probably even today as you took your time for this too :-) |
Tests are up and running 🎉 |
The EAGER 2.0 pipeline will have fully automatic consistency tests
I'll create test reference genomes with a couple of KB in size to test things quickly and then
The text was updated successfully, but these errors were encountered: