Skip to content

Commit

Permalink
Fix issue with MQC not displaying post-ar trimming FastQC results
Browse files Browse the repository at this point in the history
  • Loading branch information
jfy133 committed Jun 7, 2024
1 parent 4eb0ffe commit 8ce77e5
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
14 changes: 13 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [2.5.2] - 2024-06-07

### `Added`

### `Fixed`

- [#1037](https://github.com/nf-core/eager/issues/1073) - Fixed post-adapterremoval trimmed FastQC results not being displayed in MultiQC (to @kieren-j-mitchell for reporting, fix by @jfy133 and @TCLamnidis)

### `Dependencies`

### `Deprecated`

## [2.5.1] - 2024-02-21

### `Added`
Expand All @@ -11,7 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### `Fixed`

- [#1048](https://github.com/nf-core/eager/issues/1048) `--vcf2genome_outfile` parameter now gets prefixed by the sample_name and suffixed with `.fasta` (i.e. `<sample_name>_<vcf2genome_outfile>.fasta`). This ensures we avoid overwriting the output fasta of one sample with that of another when the option is provided. (♥ Thanks to @MeriamOs for reporting.)
- [#1048](https://github.com/nf-core/eager/issues/1048) `--vcf2genome_outfile` parameter now gets prefixed by the sample*name and suffixed with `.fasta` (i.e. `<sample_name>*<vcf2genome_outfile>.fasta`). This ensures we avoid overwriting the output fasta of one sample with that of another when the option is provided. (♥ Thanks to @MeriamOs for reporting.)
- [#1047](https://github.com/nf-core/eager/issues/1047) Changed the row some statistics were reported in the General Stats table. The File name collision fixed in 2.5.0 (see #1017) caused these statistics to be reported in the wrong row due to an added suffix.
- [#1051](https://github.com/nf-core/eager/issues/1051) An error is now thrown if input BAM files end in `.unmapped.bam`, as this breaks the bam filtering process and empties the bam files in the process. (♥ Thanks to @PCQuilis for reporting.)

Expand Down
1 change: 1 addition & 0 deletions assets/multiqc_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ top_modules:
path_filters:
- "*.truncated_fastqc.zip"
- "*.combined*_fastqc.zip"
- "*_postartrimmed_fastqc.zip"
- "bowtie2":
path_filters:
- "*_bt2.log"
Expand Down

0 comments on commit 8ce77e5

Please sign in to comment.