Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: update bclconvert to 4.2.4 #152

Merged
merged 3 commits into from
Nov 2, 2023
Merged

FEAT: update bclconvert to 4.2.4 #152

merged 3 commits into from
Nov 2, 2023

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Oct 31, 2023 •
edited
Loading

close #150

@maxulysse
Copy link
Member Author

replace #151

@github-actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4290c02

+| ✅ 156 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowDemultiplex.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-31 15:12:24

edmundmiller
edmundmiller requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, snapshots need to be bumped though, and the CHANGELOG updated!

I'll do it later if no one get's around to it.

@edmundmiller edmundmiller added this to the 1.4.0 milestone Oct 31, 2023
@maxulysse
Copy link
Member Author

LGTM, snapshots need to be bumped though, and the CHANGELOG updated!

I'll do it later if no one get's around to it.

I had the snapshot, but forgot to commit and push...
🤦

edmundmiller
edmundmiller approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we need a GitHub bot to show the diff and ask if you want to update the snapshot 🤔

It shouldn't happen automatically that defeats the purpose of a snapshot
image

@edmundmiller edmundmiller merged commit 66cfea0 into nf-core:dev Nov 2, 2023
6 checks passed
@pilare
Copy link

pilare commented Nov 10, 2023

Are there chances for a release soon with that would include latest BCL Convert? We are actively using that nfcore/demultiplex pipeline in our solution but for reproducibility reasons we do not want to use dev branch builds of the pipeline. I do see that there are 2 tasks left in 1.4.0 milestones, but one seems to be solved on other PR and the other needs some fixes in the tests. Thanks for that effort we do see a lot of value in this pipeline for the community, we would like to contribute more, but also laking bandwidth to do so :/

@Aratz Aratz mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@matthdsm matthdsm Awaiting requested review from matthdsm

Assignees

@maxulysse maxulysse

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @pilare @edmundmiller