Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix input file not a valid path #147

Merged
merged 4 commits into from
Jun 21, 2024
Merged

fix input file not a valid path #147

merged 4 commits into from
Jun 21, 2024

Conversation

Daniel-VM
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR Description

This PR attempts to fix input file errors that occur when the samplesheet contains relative paths to symbolic links. Some users experienced a 'not a valid path' error during testing.

Copy link

github-actions bot commented Jun 21, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit b780766

+| ✅ 196 tests passed       |+
#| ❔   4 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-21 10:05:50

workflows/bacass.nf Outdated Show resolved Hide resolved
@Daniel-VM Daniel-VM marked this pull request as ready for review June 21, 2024 10:36
@Daniel-VM
Copy link
Contributor Author

Suggestions have been added. Thankss ;)

Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Daniel-VM Daniel-VM merged commit 88f37ad into nf-core:dev Jun 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants