Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge nf-core Template Update v2.12 #111

Merged
merged 11 commits into from
Feb 19, 2024
Merged

Merge nf-core Template Update v2.12 #111

merged 11 commits into from
Feb 19, 2024

Conversation

Daniel-VM
Copy link
Contributor

@Daniel-VM Daniel-VM commented Feb 13, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR Description

This PR is for updating nf-core/bacass with the nf-core v2.12 template

Copy link

github-actions bot commented Feb 13, 2024

nf-core lint overall result: Passed ✅

Posted for pipeline commit 0aaeebe

+| ✅ 176 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-19 13:59:05

Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, wasnt working last week.
Looks all good to me besides small bugs in the readme.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@d4straub
Copy link
Collaborator

To solve the stalling tests EditorConfig & Prettier (after template update not executed, but github still expects it) request an nf-core core member (I'm not) to adjust that settings.

@Daniel-VM Daniel-VM merged commit 144d239 into nf-core:dev Feb 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants