Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Group ID assigned by featurecounts_deseq2.r #102

Closed
ikeller opened this issue May 26, 2020 · 4 comments
Closed

Incorrect Group ID assigned by featurecounts_deseq2.r #102

ikeller opened this issue May 26, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@ikeller
Copy link

ikeller commented May 26, 2020

featurecounts_deseq2.r expects that sample names end in "_R1" etc and will trim the last 3 characters of the sample name to obtain the group ID for DESeq2. This will not work when there are 10 or more replicates per group. In this case, you end up with twice the expected number of experimental groups, because the underscore is retained in some replicates, for example: Tissue1 and Tissue1_. It would be safer to remove everything starting at the underscore.

@drpatelh
Copy link
Member

drpatelh commented May 26, 2020

Yes, this is a bug @ikeller 👍 I could swear I fixed this already but I obviously havent!

groups <- substr(samples.vec, 1, nchar(samples.vec)-3)

The easiest and safest solution would be to split on _ and then join everything back together except the last item.

Is this the only step that is failing to deal with the double-digit replicate number?

Lucky you for having more than 9 replicates! 😆

@drpatelh drpatelh added the bug Something isn't working label May 26, 2020
@ikeller
Copy link
Author

ikeller commented May 26, 2020

Thanks for your quick reply.

I haven't spotted any other issues caused by the 2-digit replicate numbers.

@drpatelh
Copy link
Member

No worries 👍 Ill try and fix this in the next release which will hopefully be in a couple of weeks.

drpatelh added a commit to drpatelh/nf-core-atacseq that referenced this issue May 28, 2020
@drpatelh
Copy link
Member

drpatelh commented May 29, 2020

Fixed here @ikeller so will be sorted in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants