-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Group ID assigned by featurecounts_deseq2.r #102
Comments
Yes, this is a bug @ikeller 👍 I could swear I fixed this already but I obviously havent! atacseq/bin/featurecounts_deseq2.r Line 81 in 818c8dc
The easiest and safest solution would be to split on Is this the only step that is failing to deal with the double-digit replicate number? Lucky you for having more than 9 replicates! 😆 |
Thanks for your quick reply. I haven't spotted any other issues caused by the 2-digit replicate numbers. |
No worries 👍 Ill try and fix this in the next release which will hopefully be in a couple of weeks. |
featurecounts_deseq2.r expects that sample names end in "_R1" etc and will trim the last 3 characters of the sample name to obtain the group ID for DESeq2. This will not work when there are 10 or more replicates per group. In this case, you end up with twice the expected number of experimental groups, because the underscore is retained in some replicates, for example: Tissue1 and Tissue1_. It would be safer to remove everything starting at the underscore.
The text was updated successfully, but these errors were encountered: