-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dada2 MergePairs : consensus between merging & concatenating reads #803
Open
weber8thomas
wants to merge
15
commits into
nf-core:dev
Choose a base branch
from
weber8thomas:consensus-pr
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+170
−71
Open
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ec57c84
feat: consensus method for dada2_denoising
weber8thomas cc338b0
remove default values from modules.config, refactor quantile paramete…
weber8thomas 747435d
rollback to correct match & mismatch values
weber8thomas 8e46db7
fix: default value in schema not valid
weber8thomas 9ee15fe
chore: set fixed parameters when consensus disabled, use config param…
weber8thomas e073f97
chore: update newly introduced parameters prefix to : "mergepairs_con…
weber8thomas a9ed8c4
fix: fix wrongly replaced values
weber8thomas c3e4165
Merge branch 'dev' into consensus-pr
weber8thomas 11e8c7e
Apply suggestions from code review
d4straub d267dd5
Merge branch 'dev' into consensus-pr
d4straub 57b7a24
[automated] Fix code linting
nf-core-bot f8a44ad
Update nextflow_schema.json
d4straub 433c9a3
Merge branch 'dev' into consensus-pr
d4straub 871703b
chore: update default values for consensus
weber8thomas 845aac4
chore: update default values for consensus (missing match in nextflow…
weber8thomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better late than never, this seems to me as a breaking change under certain circumstances, was this intentional?