Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param --quality_type #801

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

d4straub
Copy link
Collaborator

The parameter --quality_type is added that allows specifying the quality encoding instead of relying on automatic inference thereof.
Unfortunately dada() seems not to be able to use quality type information, therefore the data needs to be read by derepFastq() first. That is a disadvantage for computational resources, so its only used when necessary, i.e. when not --quality_type "Auto".

Closes #773

This is still a draft PR, because (1) I didnt test it on actual data and (2) test data would be great.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant