Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.7.0 #648

Merged
merged 278 commits into from
Oct 19, 2023
Merged

Release 2.7.0 #648

merged 278 commits into from
Oct 19, 2023

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Oct 17, 2023

This is for release 2.7.0.

Most notable changes:

  • Added Pipeline RMarkdown summary report
  • Added ASV to OTU post-clustering with VSEARCH
  • Added Kraken2 as another taxonomic classification tool
  • Splitted --input into 3 parameters, --input now points to a sampleheet, alternatives are --input_fasta & --input_folder to accommodate nf-validation's fromSamplesheet
  • Update to nf-core tools 2.10

More details in the CHANGELOG

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

d4straub and others added 30 commits June 19, 2023 17:25
Add support for PR2 version 5 to SBDI export
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3278e5b

+| ✅ 153 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.7.0
  • readme - README did not have a Nextflow minimum version badge.
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-19 07:04:24

Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny comment.

subworkflows/local/parse_input.nf Show resolved Hide resolved
Copy link
Contributor

@tillenglert tillenglert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have some minor comments and questions, but nothing critical! :)

.github/workflows/awstest.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the taxonomic classification: Kraken2 option kind of gets lost! Is there a module or multiple modules? then at least there is more to it than just the header.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does get lost. There are three modules involved, UNTAR, KRAKEN2_KRAKEN2, and FORMAT_TAXRESULTS_KRAKEN2. None of those seem to add valuable information to the figure. I do not have a solution to it for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's true! Maybe when more tools are included one could make it more apparent! :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably the whole figure needs to be re-designed and rather exclude the details and focus on tasks or tools instead. Thats for another time ;)

docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
@d4straub
Copy link
Collaborator Author

Hm tests are failing because
ERROR ~ No such file or directory: https://zenodo.org/record/4310151/files/rdp_train_set_18.fa.gz
(which is obviously not true, probably connectivity issues)
it seems that I will eventually need to change that particular files because its not the first time they are problematic.
Will re-start the tests later and it will succeed.

@d4straub d4straub merged commit 4e48b71 into master Oct 19, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants