-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.7.0 #648
Release 2.7.0 #648
Conversation
…e/summary_report
bump-version-2.7.0dev
…e/summary_report
Add support for PR2 version 5 to SBDI export
Co-authored-by: Daniel Lundin <[email protected]>
Update pipeline summary report
Co-authored-by: Daniel Lundin <[email protected]>
Update workflow overview figure & docs
Update dependencies
Prepare 2.7.0 release
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I have some minor comments and questions, but nothing critical! :)
docs/images/ampliseq_workflow.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the taxonomic classification: Kraken2 option kind of gets lost! Is there a module or multiple modules? then at least there is more to it than just the header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does get lost. There are three modules involved, UNTAR, KRAKEN2_KRAKEN2, and FORMAT_TAXRESULTS_KRAKEN2. None of those seem to add valuable information to the figure. I do not have a solution to it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's true! Maybe when more tools are included one could make it more apparent! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, probably the whole figure needs to be re-designed and rather exclude the details and focus on tasks or tools instead. Thats for another time ;)
Co-authored-by: Till E. <[email protected]>
Hm tests are failing because |
This is for release 2.7.0.
Most notable changes:
--input
into 3 parameters,--input
now points to a sampleheet, alternatives are--input_fasta
&--input_folder
to accommodate nf-validation'sfromSamplesheet
More details in the CHANGELOG
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).