Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump versions and update software versions #310

Merged
merged 18 commits into from
Mar 17, 2024
Merged

Bump versions and update software versions #310

merged 18 commits into from
Mar 17, 2024

Conversation

ggabernet
Copy link
Member

@ggabernet ggabernet commented Mar 11, 2024 •
edited
Loading

  • bump versions
  • fix nf-core lint
  • bump igblast versions
  • update container versions
  • change report titles
  • add isotype column

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/airrflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit a8944b5

+| ✅ 200 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   1 tests had warnings |!
-| ❌   4 tests failed       |-

❌ Test failures:

  • files_exist - File must be removed: lib/Utils.groovy
  • files_exist - File must be removed: lib/WorkflowMain.groovy
  • files_exist - File must be removed: lib/NfcoreTemplate.groovy
  • files_exist - File must be removed: lib/WorkflowAirrflow.groovy

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-13 02:08:15

@ggabernet
Copy link
Member Author

The nf-core linting tests are failing as the template update is missing, which I will do in the next PR :)

@ggabernet ggabernet merged commit 699948a into nf-core:dev Mar 17, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssnn-airr ssnn-airr ssnn-airr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggabernet @ssnn-airr