Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report fix and other bugfixes #258

Merged
merged 19 commits into from
May 29, 2023
Merged

Report fix and other bugfixes #258

merged 19 commits into from
May 29, 2023

Conversation

ggabernet
Copy link
Member

@ggabernet ggabernet commented May 23, 2023 •
edited
Loading

Solves #257
Solves #252
Solves #242

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/airrflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7ee7461

+| ✅ 159 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-24 21:32:53

@ggabernet ggabernet requested a review from ssnn-airr May 24, 2023 20:30
@ggabernet ggabernet changed the title Template update and report fix Report fix and other bugfixes May 24, 2023
@ggabernet ggabernet merged commit b262243 into nf-core:dev May 29, 2023
@ggabernet ggabernet deleted the report-fix branch June 22, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssnn-airr ssnn-airr ssnn-airr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggabernet @ssnn-airr