Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge template updates nf-core v2.6 #209

Merged
merged 6 commits into from
Dec 2, 2022
Merged

Merge template updates nf-core v2.6 #209

merged 6 commits into from
Dec 2, 2022

Conversation

ggabernet
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/airrflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ggabernet ggabernet marked this pull request as ready for review December 2, 2022 09:10
@FriederikeHanssen FriederikeHanssen self-assigned this Dec 2, 2022
FriederikeHanssen
FriederikeHanssen reviewed Dec 2, 2022
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
FriederikeHanssen
FriederikeHanssen approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just wondering about the version in the nextflow.config

@github-actions
Copy link

github-actions bot commented Dec 2, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 88c3ff6

+| ✅ 154 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: lib/WorkflowAirrflow.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-12-02 10:50:05

@ggabernet ggabernet merged commit d61f348 into nf-core:dev Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees

@FriederikeHanssen FriederikeHanssen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggabernet @FriederikeHanssen @nf-core-bot