Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge template updates v2.5.1 #183

Merged
merged 16 commits into from
Sep 16, 2022
Merged

Conversation

ggabernet
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/airrflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Sep 14, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 64631ea

+| ✅ 151 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: lib/WorkflowAirrflow.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.5.1
  • Run at 2022-09-15 15:19:31

@ggabernet ggabernet changed the base branch from master to dev September 14, 2022 18:16
@ggabernet ggabernet changed the title merge template updattes merge template updates v2.5.1 Sep 15, 2022
@ggabernet ggabernet changed the base branch from dev to master September 15, 2022 09:31
@ggabernet ggabernet changed the base branch from master to dev September 15, 2022 09:31
CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines 20 to +25
### `Dependencies`

| Dependency | Old version | New version |
| ---------- | ----------- | ----------- |
| multiqc | 1.12 | 1.13 |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FriederikeHanssen We should do that

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggabernet ggabernet merged commit cba80f7 into nf-core:dev Sep 16, 2022
@ggabernet ggabernet deleted the merge-template-updattes branch October 1, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants