Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete labels and versions #163

Merged
merged 14 commits into from
Apr 27, 2022
Merged

Complete labels and versions #163

merged 14 commits into from
Apr 27, 2022

Conversation

ggabernet
Copy link
Member

@ggabernet ggabernet commented Apr 23, 2022 •
edited
Loading

Changes

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/airrflow branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Apr 23, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit d74004a

+| ✅ 145 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: lib/WorkflowAirrflow.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.2
  • Run at 2022-04-27 13:59:58

d4straub
d4straub approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few minor comments.

I do think you could adress the linting warnings, e.g. ignore [files_exist](https://nf-co.re/tools-docs/lint_tests/files_exist.html) - File not found: conf/igenomes.config, remove TODO string and add the param singlecell.

modules/local/alakazam/alakazam_shazam_repertoires.nf Outdated Show resolved Hide resolved
modules/local/changeo/changeo_buildtrees.nf Show resolved Hide resolved
modules/local/presto/presto_buildconsensus.nf Show resolved Hide resolved
@ggabernet
Copy link
Member Author

Thanks @d4straub, I've also fixed the linting warnings now!

@ggabernet ggabernet merged commit b8352dc into nf-core:dev Apr 27, 2022
@ggabernet ggabernet deleted the labels branch October 1, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggabernet @d4straub