Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add proof tracking event for analytics #97

Merged
merged 6 commits into from
Dec 9, 2024
Merged

feat: add proof tracking event for analytics #97

merged 6 commits into from
Dec 9, 2024

Conversation

dprats
Copy link
Collaborator

@dprats dprats commented Dec 9, 2024

for analytics, send proof event via CLI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e22b34a):

https://nexus-cli--pr97-dprats-send-proof-ev-j26gk3ng.web.app

(expires Mon, 16 Dec 2024 21:57:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 815ec4c632754f56eccfacfc0919559f5a85a0f1

@dprats dprats marked this pull request as ready for review December 9, 2024 21:27
collinjackson
collinjackson reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@collinjackson collinjackson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the "progress" event? It seems redundant, and mostly will get discarded as a duplicate due to repeats in close succession

clients/cli/src/prover.rs Outdated Show resolved Hide resolved
@dprats
Copy link
Collaborator Author

dprats commented Dec 9, 2024

yup. removed

@collinjackson collinjackson self-requested a review December 9, 2024 23:10
@dprats dprats merged commit 1b0ac9e into main Dec 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collinjackson collinjackson collinjackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dprats @collinjackson