fix: fix writing prover-id to file and reading it #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The CLI wasn't saving autogenerated prover IDs in certain error cases. When reading the prover ID file failed, some error paths didn't properly handle saving the default ID.
Primary changes
get_or_generate_prover_id
to handle some missing cases (e.g. hitting an error, missing file, etc...)Secondary changes
Your current prover identifier is
shows up in theSetting up CLI configuration.
section (see image below). Before this PR, the prover id was logged in same section as the web socket connection. This was misleading.