feat: protoc should not be required #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: #55.
Current state of the world (before this PR)
The CLI requires
protoc
to be installed in user's computer to run. However, the protobuf files are already in the repo, so this is actually unnecessary.What this PR does
Main Intent
build.rs
so it checks for the previously generated protobuf files... so it does not block on ifprotoc
is missing.cargo.toml
so it does not use prost-build (which requires protoc be installed)Secondary Intent
How I tested this PR
protoc
from my computercargo run
to make sure that the app still built and ran <-- this passes as expectedinstall.sh
to make sure that the app still built and ran <--- this is currently NOT working because it does a fresh install from github (not the code in this PR).