Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: protoc should not be required #194

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

dprats
Copy link
Collaborator

@dprats dprats commented Dec 12, 2024

This PR addresses: #55.

Current state of the world (before this PR)

The CLI requires protoc to be installed in user's computer to run. However, the protobuf files are already in the repo, so this is actually unnecessary.

What this PR does

Main Intent

  1. Updates build.rs so it checks for the previously generated protobuf files... so it does not block on if protoc is missing.
  2. Updates the CI file so it does not install protoc
  3. Updates the cargo.toml so it does not use prost-build (which requires protoc be installed)

Secondary Intent

  1. Bumps the version number

How I tested this PR

  1. I removed protoc from my computer
  2. I tested so that:
$ protoc --version
> zsh: command not found: protoc
  1. I ran the cargo run to make sure that the app still built and ran <-- this passes as expected
# to clean the local builds
$ cargo clean

# build to see proving
$ cargo run --release ...
  1. I ran the install.sh to make sure that the app still built and ran <--- this is currently NOT working because it does a fresh install from github (not the code in this PR).

Copy link

Visit the preview URL for this PR (updated for commit 8ec2d5c):

https://nexus-cli--pr194-dprats-protoc-should-v52ggdyk.web.app

(expires Thu, 19 Dec 2024 19:02:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 815ec4c632754f56eccfacfc0919559f5a85a0f1

@dprats dprats marked this pull request as ready for review December 12, 2024 21:37
@dprats dprats merged commit e82bc71 into main Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants