Restore description #184
Merged
Restore description #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore use of the `--description` option for `augur export v2`, which was lost during the major refactoring of the workflow in <#76> Allows for build specific descriptions, similar to the `auspice_config` based on array_builds.smk.¹ If a build specific description is not provided, then defaults to the workflow's `config/description.md`. ¹ <https://github.com/nextstrain/seasonal-flu/blob/b0ff43d8ccce7e28bf81350eaf8642c79908232f/workflow/snakemake_rules/array_builds.smk#L66-L67>
huddlej
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Thank you for picking this up, @joverlee521. This looked good to me locally. I added a commit to pull in the same change for nextflu-private builds and made a couple of suggestions for the updated description.
Remove section on forecasts and refer to "Acknowledgements" option. Co-authored-by: John Huddleston <[email protected]>
|
Thanks for catching those changes @huddlej! Merging now and expecting this to be run with this week's updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Restore use of the
--descriptionoption foraugur export v2, which was lost during the major refactoring of the workflow in #76.Allows for build specific descriptions, similar to the
auspice_configbased on array_builds.smk. If a build specific description is not provided, then defaults to the workflow'sconfig/description.md.Related issue(s)
Resolves #182
Checklist