Deploy private nextflu builds to Netlify #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This basic workflow is able to build the empty site and deploy to staging-private-nextflu.netlify.app, which is still password protected. The private.nextflu.org site is still built using the old Auspice version in https://github.com/blab/nextflu and deployed to Netlify. This requires an older version of Ruby (2.3.7) and dependencies that others have had trouble installing on the new M1 macs. Instead of depending on my old mac to deploy the private builds, create to a GitHub Action workflow to deploy the site that anyone on the Nextstrain team can run. I've opted for this route instead of trying to update the dependencies for the old Auspice because the ultimate goal is to sunset the private site. This seemed like less work than fiddling with dependencies.
Adds an input for the AWS Batch Job ID to be able to attach to a private nextflu build and build the site with the output Auspice JSONs. Requires the Auspice JSONs to be in `auspice-who` since that is the output directory for the private.nextflu.org profile.¹ ¹ https://github.com/nextstrain/seasonal-flu/blob/80f3be31a56abd92908a56343edb7af48fa38274/profiles/private.nextflu.org/export.smk#L17
The default will now deploy to the production site at private.nextflu.org. If the input is true, then will deploy to the staging site at staging-private-nextflu.netlify.app
|
Tested deploying with the latest private builds from yesterday. Triggered the deployment to staging with: Triggered the deployment to production with: Both runs completed successfully, but logs show they uploaded 0 files because I had already deployed to Netlify manually this morning. Can test again with next week's builds. |
|
Today's private nextflu builds have been successfully deployed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The private.nextflu.org site is still built using the old Auspice
version in https://github.com/blab/nextflu and deployed to Netlify.
This requires an older version of Ruby (2.3.7) and dependencies that
others have had trouble installing on the new M1 macs. Instead of
depending on my old mac to deploy the private builds, use a GitHub
Action workflow to deploy the site that anyone on the Nextstrain team
can run.
I've opted for this route instead of trying to update the dependencies
for the old Auspice because the ultimate goal is to sunset the private
site. This seemed like less work than fiddling with dependencies.
Note
For this new workflow, I had to add ruby/setup-ruby@v1 to the Nextstrain's list of allowed actions.
Next steps
This can be run manually for now, but would be best to connect with the private builds to auto-deploy to the private site when the build succeeds.
The easiest route would be to keep the private builds attached to the AWS Batch job and then trigger this new workflow
when the job is complete. The private builds are running up to ~4hrs, which is within GH's 6hr job limit. However, I'm not doing this now since we still have limited concurrency for GH Actions.