Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new augur ancestral interface #119

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Use new augur ancestral interface #119

merged 1 commit into from
Aug 30, 2023

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Aug 29, 2023

Description of proposed changes

Updates augur ancestral rule in the core workflow to generate ancestral translations in addition to ancestral nucleotide sequences. Removes the separate rule for translation and the corresponding custom script. Updates all downstream rules to reference a new single muts.json file. Rules that depended on the translations with internal node sequences do not need to change, since the output files from the updated ancestral rule maintain the same name.

Testing

  • Tested with nextflu-private builds
  • Checks pass

Updates augur ancestral rule in the core workflow to generate ancestral
translations in addition to ancestral nucleotide sequences. Removes the
separate rule for translation and the corresponding custom script.
Updates all downstream rules to reference a new single `muts.json` file.
Rules that depended on the translations with internal node sequences do
not need to change, since the output files from the updated ancestral
rule maintain the same name.
@huddlej huddlej requested a review from rneher August 29, 2023 22:54
Copy link
Member

@rneher rneher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! this looks great to me!

@huddlej huddlej merged commit d951b6d into master Aug 30, 2023
6 checks passed
@huddlej huddlej deleted the use-new-ancestral branch August 30, 2023 17:00
joverlee521 added a commit that referenced this pull request Sep 1, 2023
Follow up on #119.
See f9a06aa commit message for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants