Update builds to use --env options
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better to be explicit about which envvars are being passed to runtimes rather than rely on the automatic variables passed through. The upload workflow requires the rethinkdb secrets to access Fauna and the AWS secrets to upload files to S3. The public and private builds just need the AWS secrets to launch jobs on AWS Batch and to download files from S3. These are all GitHub Action secrets that are being inherited by the reusable workflow and available as envvars in the GitHub Action job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Better to be explicit about which envvars are being passed to runtimes rather than rely on the automatic variables passed through.
The upload workflow requires the rethinkdb secrets to access Fauna and the AWS secrets to upload files to S3.
The public and private builds just need the AWS secrets to launch jobs on AWS Batch and to download files from S3.
These are all GitHub Action secrets that are being inherited by the reusable workflow and available as envvars in the GitHub Action job.
Related issue(s)
Follow up on #111, following @tsibley's recommendation to be explicit about envvars.
Testing
I meant to run this as today's workflow but oh well. Will test next week.Yesterday's upload job failed, so testing this upload workflow today.