Fix (some) header metadata generation in un-hydrated content [#1011] #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
nextstrain-s-fix-feed-d-e5kniw
* Switch from using `react-helmet` to `next/head` for populating `<head>` element in pages * Swap various `<Helmet>` usage to `<Head>` * Migrate social media-related metadata headers to `_document.tsx` This is a preliminary step that fixes feed auto-discovery; subsequent work will get full metadata headers (i.e., OpenGraph, etc) into un-hydrated renders.
genehack
force-pushed
the
fix-feed-disco-1011
branch
from
77b9565 to
45f6245
Compare
victorlin
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Checked the diff of un-hydrated content, looks good
diff details
diff \
<(curl https://next.nextstrain.org/ | tidy) \
<(curl https://nextstrain-s-fix-feed-d-e5kniw.herokuapp.com/ | tidy)8a9,17
> <link rel="me" href="https://mstdn.science/@nextstrain">
> <link href="https://nextstrain.org/blog/atom.xml" rel="alternate"
> title="Atom feed for nextstrain.org/blog" type=
> "application/atom+xml">
> <link href="https://nextstrain.org/blog/feed.json" rel="alternate"
> title="JSON feed for nextstrain.org/blog" type="application/json">
> <link href="https://nextstrain.org/blog/rss2.xml" rel="alternate"
> title="RSS2 feed for nextstrain.org/blog" type=
> "application/rss+xml">
40c49
< "/_next/static/chunks/webpack-f18a76835c777373.js" defer
---
> "/_next/static/chunks/webpack-022efe4e2824bafb.js" defer
52c61
< "/_next/static/chunks/pages/index-1592d50a80c28441.js" defer
---
> "/_next/static/chunks/pages/index-3b7ab159a7f6b20f.js" defer
55c64
< "/_next/static/gORQO5sWexyjqbbXhAT3X/_buildManifest.js" defer
---
> "/_next/static/bucZKFJf16fMJZcQAu4-O/_buildManifest.js" defer
58c67
< "/_next/static/gORQO5sWexyjqbbXhAT3X/_ssgManifest.js" defer
---
> "/_next/static/bucZKFJf16fMJZcQAu4-O/_ssgManifest.js" defer
65c74
< {"props":{"pageProps":{}},"page":"/","query":{},"buildId":"gORQO5sWexyjqbbXhAT3X","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}
---
> {"props":{"pageProps":{}},"page":"/","query":{},"buildId":"bucZKFJf16fMJZcQAu4-O","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
react-helmettonext/headfor populating<head>element in pages<Helmet>usage to<Head>_document.tsxThis is a preliminary step that fixes feed auto-discovery; subsequent work will get full metadata headers (i.e., OpenGraph, etc) into un-hydrated renders.
Related issue(s)
Closes #1011
Checklist