Skip to content

Commit

Permalink
Check types in CI
Browse files Browse the repository at this point in the history
Previously, the only enforcement of TypeScript was through ESLint rules
from @typescript-eslint.
  • Loading branch information
victorlin committed Nov 19, 2024
1 parent e1df53f commit 4fa273c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ jobs:
- run: npm run lint:static-site
- run: node ./scripts/check-resource-index-match.js

type-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- run: npm ci
- run: npm run type-check

# Build into Heroku slug so we can deploy the same build that we test.
build:
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"lint": "npm run lint:server",
"lint:server": "DEBUG=eslint:cli-engine npx eslint --max-warnings=0 --ext .js,.jsx .",
"lint:static-site": "cd static-site && DEBUG=eslint:cli-engine npx eslint --max-warnings=0 --ext .js,.jsx,.ts,.tsx .",
"type-check": "cd static-site && tsc",
"server": "node server.js",
"groups": "node server.js --app ./src/groupsApp.js",
"start": "npm run server",
Expand Down

0 comments on commit 4fa273c

Please sign in to comment.