-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): update linux-aarch64 sha in bioconda publish script #1430
Conversation
Bioconda now publishes linux-aarch64 packages for nextclade as well, so those shas also should be updated. bioconda/bioconda-recipes#46185
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Is there no need to also update https://github.com/nextstrain/nextclade/blob/514c5c50ef8f4c58f542cb2abbfbf967370b9268/scripts/update-bioconda.py? I don't quite remember how this works. Upon quick look, I think the change of selector comments like Also, is |
Yes that script would also no longer work, good spot! I don't know whether we still use that at all though. I think that arm64 === osx and arm64, i.e. the osx is unnecessary but I thought I make the os explicit as well as it's not super obvious that aarch64 is Linux and arm64 is Mac. Especially since arm64 is generally a synonym for aarch64 for Linux at least. |
We definitely use this script, it does most of the work: nextclade/scripts/publish_bioconda Lines 82 to 83 in 514c5c5
That's weird. "AArch64 and "ARM64" are synonyms. The official name of the architecture is "AArch64" and "ARM64" is a colloquial name (probably to make it sound similar to "AMD64"). There is no "ARM for Linux" and "ARM for Mac", these are all flavors of the same architecture licensed from ARM, and you can install any software on any hardware if you try hard enough (e.g. https://asahilinux.org), barring the artificial limitations by Apple. Are these comments documented somewhere? Where do they come from? Wouldn't it be wiser to use generally accepted target triplet nomenclature instead of inventing random stuff? |
Ah I missed that, thanks! Yes they are documented here: https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#preprocessing-selectors
They screwed up the separation of os and arch when they made We can be explicit by using redundancy:
We have to use different terms for arm64/aarch64 depending on platform though - it's annoying :/ |
Oh no, I have to fix this PR here otherwise we will not update it for aarch64 🙃 |
Closed in favor of #1434 |
Bioconda now publishes linux-aarch64 packages for nextclade as well, so those shas also should be updated.
bioconda/bioconda-recipes#46185