Map clades not in clade-legacy-mapping.yml to itself #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids those clades being mapped to `?` We may want to discontinue legacy mapping at some point and just report short clades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we add new clades, we need to add them to
clade-legacy-mapping.ymlin this repo.This is easy to forget as all the other changes are in
ncovdirectly.If we don't add them to the mapping file, they end up as
?in metadata.tsv, which is bad.This PR maps new clades not in
clade-legacy-mapping.ymlto itself, rather than to?.We may want to discontinue legacy mapping at some point and just report short clades
An alternative here is to error when we find this situation - so that we are directly aware of the issue and can fix the mapping. But the current state is worse than either of the two options.
Testing
Tested locally that new clades that are not in
clade-legacy-mapping.ymlend up mapped to itself.